Repository navigation
Conversation
krzys13
force-pushed
the
24-add-error-notifications-via-discord-on-task-failures
branch
2 times, most recently
from
November 7, 2026 12:11
12b8b16 to
211b458
Compare
krzys13
marked this pull request as ready for review
November 7, 2026 12:14
krzys13
enabled auto-merge
November 7, 2026 14:57
krzys13
disabled auto-merge
November 7, 2026 14:57
krzys13
force-pushed
the
24-add-error-notifications-via-discord-on-task-failures
branch
from
November 7, 2026 15:10
211b458 to
7069882
Compare
…zation - add a singleton webhook sender using DISORD_WEBHOOK_URL - introduce typed notification payloads with INFO, WARNING and ERROR levels - format notifications as embeds with a title, description and timestamp - add a shared webhook manager for commands - connect synchronization failure notifications to the --webhook (-w) flag - include the error message or exit code in failure notifications - log webhook HTTP and network failures without replacing the command result - introduce an in-memory message buffer and repetition-limit configuration
krzys13
force-pushed
the
24-add-error-notifications-via-discord-on-task-failures
branch
from
November 7, 2026 16:08
7069882 to
cf57051
Compare
mini-bomba
reviewed
Nov 9, 2026
mini-bomba
left a comment
mini-bomba
left a comment
Member
There was a problem hiding this comment.
2/3 of the util files are not needed
you're trying to fix edge cases that will not be reached
- we don't really need rate limiting, we will not be sending more than 1 message per command run (and a command runs every minute at worst - discord allows us to send 5 messages every 10 seconds)
- this whole manager/class/singleton business smells of java practices, all you need here is a simple function that just sends a webhook payload to the webhook url
krzys13
force-pushed
the
24-add-error-notifications-via-discord-on-task-failures
branch
from
November 10, 2026 21:44
2ea7992 to
cd506f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.